mem_watcher:添加打印页面修饰符标志gfp_mask的功能 #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
syxl-time
commented
Jul 19, 2024
syxl-time
commented
syxl-time
requested review from
helight,
LinkinPF and
chenamy2017
as code owners
chenamy2017
reviewed
Jul 22, 2024
| if ((flag & GFP_HIGHUSER) == GFP_HIGHUSER) strcat(combined, "GFP_HIGHUSER | "); | ||
| if ((flag & GFP_HIGHUSER_MOVABLE) == GFP_HIGHUSER_MOVABLE) strcat(combined, "GFP_HIGHUSER_MOVABLE | "); | ||
| if ((flag & GFP_TRANSHUGE_LIGHT) == GFP_TRANSHUGE_LIGHT) strcat(combined, "GFP_TRANSHUGE_LIGHT | "); | ||
| if ((flag & GFP_TRANSHUGE) == GFP_TRANSHUGE) strcat(combined, "GFP_TRANSHUGE | "); |
There was a problem hiding this comment.
根据如下定义，你的输出将会是“"GFP_NOIO | GFP_NOFS | GFP_USER”，是否符合你的预期？还是只输出一个GFP_USER就够了？
#define GFP_NOIO (___GFP_RECLAIMABLE)
#define GFP_NOFS (___GFP_RECLAIMABLE | ___GFP_IO)
#define GFP_USER (___GFP_RECLAIMABLE | ___GFP_IO | ___GFP_FS | ___GFP_HARDWALL)
There was a problem hiding this comment.
是都会被打印出来，这样可以看出标志的所有特性
chenamy2017
reviewed
Jul 22, 2024
| if (flag & ___GFP_THISNODE) strcat(separate, "___GFP_THISNODE | "); | ||
| if (flag & ___GFP_ACCOUNT) strcat(separate, "___GFP_ACCOUNT | "); | ||
| if (flag & ___GFP_ZEROTAGS) strcat(separate, "___GFP_ZEROTAGS | "); | ||
| if (flag & ___GFP_SKIP_KASAN_POISON) strcat(separate, "___GFP_SKIP_KASAN_POISON | "); |
There was a problem hiding this comment.
以上if语句，可以定义一个结构体数组，用for循环实现，这样标志变动只需要修改数组即可。如：
gfp_list[] = {
{___GFP_DMA, "___GFP_DMA"},
{___GFP_HIGHMEM, "___GFP_HIGHMEM"},
//...
};
//for (gfp_list)
There was a problem hiding this comment.
改好了师兄，修改为for循环判断标志位了
chenamy2017
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.