Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] - Needs support for the following key bindings #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iofreddy85
Copy link

@iofreddy85 iofreddy85 commented Aug 18, 2023

Hey, I hope somebody is still supporting this awesome mod!!

I'm just a full stack web developer and couldn't help to check the code to see if I could fix/add the missing key bindings for the EVA buttons configurations.

I know nothing about Unity (just a little c#), and have no idea how to compile this, but I added some comments next to the lines I think should be modified to support the key bindings for the EVA input section specifically for joystick since I'm playing with a joystick. I already extracted the GameSettings constants and double checked that they're the right ones to add.

For the joystick axis settings, I don't know how you'd differentiate between left / right, up / down, etc, but I'm guessing it should be pretty straight forward.

Please let me know if you have time to do this or maybe point me to somebody who can?
Otherwise I guess I'll have to learn some Unity.

Here is a picture of the inputs I'm talking about:
eva-input

cc: @linuxgurugamer

@linuxgurugamer
Copy link
Owner

I don't understand, you do a PR but then say to not merge?
Can you explain, please?

And yes, i do support it

@JonnyOThan
Copy link

I think they mean they made a change that looks right but it's not tested or compiled (the changes are commented out in any case). It's just a starting point.

@linuxgurugamer
Copy link
Owner

Well, they shouldn't do a PR if they are working on it, it's very confusing. I really don't know how to deal with this so that I actually see it when they feel they are ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants