Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#918 Fixing updated newsletter forms #922

Merged
merged 3 commits into from
Jun 28, 2024
Merged

#918 Fixing updated newsletter forms #922

merged 3 commits into from
Jun 28, 2024

Conversation

thetwopct
Copy link
Collaborator

Work for #918

@cjyabraham
Copy link
Collaborator

Event footer
A big improvement on what we had. Why not just make all 4 input fields the same width? It looks odd that the country field is slightly narrower?

Non-event footer
LGTM

@thetwopct
Tweak desktop layout
679b39f 
Signed-off-by: James Hunt <[email protected]>
@thetwopct
Copy link
Collaborator Author

Why not just make all 4 input fields the same width? It looks odd that the country field is slightly narrower?

Have tweaked. Don't think it works when all the same size. Especially the submit button.

@thetwopct thetwopct marked this pull request as ready for review June 27, 2024 17:51
@thetwopct
Organising CSS
a52f0f7 
Signed-off-by: James Hunt <[email protected]>
@thetwopct
Copy link
Collaborator Author

Updated. Only included .legal-consent-container {} once, no need to have it twice.

@cjyabraham cjyabraham merged commit f691d04 into main Jun 28, 2024
6 checks passed
@cjyabraham cjyabraham deleted the newsletter-forms branch June 28, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyabraham cjyabraham cjyabraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thetwopct @cjyabraham