Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 动效增加开关 #245

Merged
merged 1 commit into from
Oct 25, 2024
Merged

feat: 动效增加开关 #245

merged 1 commit into from
Oct 25, 2024

Conversation

Whale107
Copy link
Contributor

@Whale107 Whale107 commented Oct 23, 2024

动效增加开关,通过DGuiApplication::testAttribute(DGuiApplication::HasAnimations)接口和环境变量DTK_DISABLE_ANIMATION_***控制动效总开关和单个动效开关

Log: 动效增加开关

deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Oct 23, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#245
Comment on lines 65 to 68
#define ENABLE_ANIMATIONS (!qEnvironmentVariableIsSet("DTK_DISABLE_ANIMATIONS"))
#define ENABLE_ANIMATION_RADIOBUTTON (!qEnvironmentVariableIsSet("DTK_DISABLE_ANIMATION_RADIOBUTTON"))
#define ENABLE_ANIMATION_CHECKBOX (!qEnvironmentVariableIsSet("DTK_DISABLE_ANIMATION_CHECKBOX"))
#define ENABLE_ANIMATION_PROGRESSBAR (!qEnvironmentVariableIsSet("DTK_DISABLE_ANIMATION_PROGRESSBAR"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是可以直接用 dstyle 里面的宏定义?
chameleonstyle 是从 dstyle 继承的,是可以访问到 dstyle 的头文件定义的宏的。 重复定义

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Oct 24, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#245
Copy link
Contributor

@kegechen kegechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

统一使用 DGuiApplicationHelper::testAttribute(DGuiApplicationHelper::HasAnimations)

动效增加开关,通过接口DGuiApplicationHelper::testAttribute(DGuiApplicationHelper::IsDXcbPlatform)和环境变量DTK_DISABLE_ANIMATION_***控制动效总开关和单个动效开关

Log: 动效增加开关
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Oct 25, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#245
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen, Whale107

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Whale107
Copy link
Contributor Author

统一使用 DGuiApplicationHelper::testAttribute(DGuiApplicationHelper::HasAnimations)

@Whale107 Whale107 closed this Oct 25, 2024
@Whale107 Whale107 reopened this Oct 25, 2024
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Oct 25, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#245
@kegechen kegechen merged commit 5ddde12 into linuxdeepin:master Oct 25, 2024
30 of 34 checks passed
FeiWang1119 pushed a commit to linuxdeepin/qt6integration that referenced this pull request Oct 28, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants