Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tweak menu animation #240

Open
wants to merge 1 commit into
base: dev/animation
Choose a base branch
from

Conversation

FeiWang1119
Copy link

1.add antialising
2.add shadow
3.add submenu background

Log:

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 22, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#240
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 22, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#240
1.add antialising
2.add shadow
3.add submenu background

Log:
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 22, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#240
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • ChameleonMovementAnimation::ChameleonMovementAnimation构造函数中,将setDuration的值从150修改为50,可能影响动画的流畅度和用户体验。
  • drawMenuItemBackground函数中,新增代码块判断type是否为子菜单,并根据主题类型设置背景颜色,但未考虑主题的深色模式和亮色模式下颜色的差异。
  • drawMenuItemBackground函数中,新增了painter->setRenderHint(QPainter::Antialiasing);,这可能会影响性能,尤其是在大量绘制时。
  • drawMenuItemBackground函数中,新增了drawShadow函数调用,但没有提供该函数的实现细节,可能会导致未处理的异常。

是否建议立即修改:

  • 确认更改setDuration值是否符合设计要求,并评估对用户体验的影响。
  • 验证新增代码块是否正确处理了主题的深色模式和亮色模式,以保持一致的用户界面风格。
  • 评估新增的setRenderHint对性能的影响,并在必要时进行优化。
  • 确保drawShadow函数的实现是正确的,并且不会引入新的问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants