Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add round and remove shadow for menu item #231

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

FeiWang1119
Copy link
Contributor

add round and remove shadow for menu item

Log:

@FeiWang1119 FeiWang1119 requested a review from 18202781743 July 9, 2024 07:59
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Jul 9, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#231
@FeiWang1119
Copy link
Contributor Author

_._20240709161506.mp4

deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Jul 9, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#231
@FeiWang1119 FeiWang1119 requested review from zccrs and kegechen July 9, 2024 08:19
@18202781743
Copy link
Contributor

加圆角和移除阴影的代码分开提交吧,

deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 9, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#231
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 9, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#231
add round and remove shadow for menu item

Log:
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 删除了menu_shadow.svg文件,需要确认这是否是有意为之,因为这会影响到阴影的绘制。
  • 修改了PM_MenuHMargin的返回值,从0改为6,需要确认这个改动是否符合设计要求。
  • 移除了RESOURCES标签和resources.qrc文件中的menu_shadow.svg文件,需要检查是否有其他代码或插件依赖于此文件,以避免潜在的运行时错误。

是否建议立即修改:

  • 是,特别是如果移除menu_shadow.svg会导致运行时错误,或者如果PM_MenuHMargin的改动会影响到菜单项的水平边距。需要确保这些更改不会影响现有的功能和用户体验。

deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 9, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#231
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, FeiWang1119

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FeiWang1119 FeiWang1119 merged commit d5b51b0 into linuxdeepin:dev/animation Aug 9, 2024
19 of 20 checks passed
FeiWang1119 pushed a commit to linuxdeepin/qt6integration that referenced this pull request Sep 25, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants