Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复ftp共享目录图片打开显示空白 #146

Closed
wants to merge 1 commit into from
Closed

fix: 修复ftp共享目录图片打开显示空白 #146

wants to merge 1 commit into from

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented Oct 9, 2024

修复ftp共享目录图片打开显示空白

Bug: https://pms.uniontech.com/bug-view-275425.html
Log: 修复ftp共享目录图片打开显示空白

修复ftp共享目录图片打开显示空白

Bug: https://pms.uniontech.com/bug-view-275425.html
Log: 修复ftp共享目录图片打开显示空白
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在处理FTP图片时,没有对tmpfile.open()的结果进行错误处理。
  • QNetworkAccessManagerfinished信号连接了一个匿名lambda,这可能会导致内存泄漏,因为连接的lambda对象没有被存储在任何地方。
  • QTemporaryFile的使用没有考虑到在多线程环境下可能出现的竞态条件。
  • QNetworkRequest的构造函数应该使用QNetworkRequest::FromUrl来避免手动设置url()方法。
  • LibUnionImage_NameSpace::loadStaticImageFromFile函数调用可能依赖于QPixmap的构造结果,但当前的调用顺序没有反映这种依赖关系。
  • 代码中没有对QNetworkReply的错误进行处理,例如网络连接失败或者文件不存在。

是否建议立即修改:

@myk1343 myk1343 closed this by deleting the head repository Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants