Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dicon proxy engine read #215

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

kegechen
Copy link
Contributor

@kegechen kegechen commented Jan 2, 2024

fix ut_dciiconengine failed on dark theme
fix: DIconProxyEngine read not ensureEngine

@kegechen kegechen requested a review from 18202781743 January 2, 2024 07:29
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jan 2, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#215
@kegechen kegechen requested a review from FeiWang1119 January 2, 2024 07:30
18202781743
18202781743 previously approved these changes Jan 2, 2024
@kegechen kegechen force-pushed the fix_DIconProxyEngine_read branch from 4f53b3a to 3717b80 Compare January 2, 2024 07:52
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jan 2, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#215
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kegechen pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Jan 2, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#215
@kegechen
Copy link
Contributor Author

kegechen commented Jan 4, 2024

read and write operations not match
Trying to construct an instance of an invalid type, type id:xxx
add normal.dark, hover.dark, pressed.dark
@kegechen kegechen force-pushed the fix_DIconProxyEngine_read branch from 3717b80 to bb288d0 Compare January 4, 2024 01:46
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 4, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@kegechen kegechen merged commit 0dfac4c into linuxdeepin:master Jan 4, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants