chore: option to use KIconThemes instead of Qt5XdgIconLoader #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doc Check bot |
asterwyx
requested changes
Mar 13, 2023
提供选项，使用 KIconThemes 的 KIconEngine 取代 Qt5XdgIconLoader Log:
zccrs
requested changes
Mar 13, 2023
| @@ -87,10 +92,14 @@ static inline QIconEngine *createBuiltinIconEngine(const QString &iconName) | |||
| return new DBuiltinIconEngine(iconName); | |||
| } | |||
|
|
|||
| #ifndef DTK_DISABLE_LIBXDG | |||
| #ifndef DTK_DISABLE_ICON_ENGINE_PROXY | |||
| static inline QIconEngine *createXdgProxyIconEngine(const QString &iconName) | |||
| @@ -19,7 +21,8 @@ set(CMAKE_INCLUDE_CURRENT_DIR ON) | |||
| set(CMAKE_EXPORT_COMPILE_COMMANDS ON) | |||
|
|
|||
| # Set build option | |||
| option(DTK_DISABLE_LIBXDG "Disable libxdg" OFF) | |||
| option(DTK_DISABLE_ICON_ENGINE_PROXY "Disable icon engine, use QIcon::fromTheme() as possible fallback" OFF) | |||
|
TAG Bot New tag: 5.6.21 |
|
TAG Bot New tag: 5.6.22 |
|
目前没空处理这个了，暂时关闭，回头可能要单独重搞下这个或者 fork 一份 KIconTheme 改改用 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
提供选项，使用 KIconThemes 替代 Qt5XdgIconLoader。
目前加了一些 ifdef 去判断用哪个，但我们还有必要保留使用 Qt5XdgIconLoader 的实现吗？
相关：