Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix cursor anomaly issue #899

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

Kakueeen
Copy link
Contributor

@Kakueeen Kakueeen commented Sep 2, 2024

LiHua000
LiHua000 previously approved these changes Sep 3, 2024
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • updateSettings函数中,else if语句的条件判断应该使用!fileName.isEmpty()来确保只有在文件名不为空时才设置字体。
  • loadLexer函数中,创建SciLexer时不需要重复设置字体,因为已经通过setDefaultFont在创建时设置了。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign deepin-mozart for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit 39aef79 into linuxdeepin:master Sep 3, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants