Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The shortcuts are not synchronized with the locator content #896

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Kakueeen
Copy link
Contributor

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • keySequencesToNativeString函数中,使用std::copy_ifstd::transform可能会导致不必要的性能开销,因为这些函数在C++11中已经被优化。建议直接遍历sequences并使用lambda函数来过滤和转换键序列。
  • keySequencesToNativeString函数在actionmanager/command.hplugins/option/optioncore/mainframe/shortcutsettingwidget.cpp中被重复定义,应该考虑合并到一个文件中。
  • ShortcutSettingWidgetPrivate::checkConflict函数中,直接使用keySequencesToNativeString可能会导致不必要的函数调用和内存分配。建议在检查冲突时直接使用QKeySequencetoString方法。
  • ShortcutSettingWidgetPrivate::updateShortcut函数中的keyStrList变量应该声明为const auto &,以避免不必要的拷贝。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign toberyan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit 22af767 into linuxdeepin:master Sep 2, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants