Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [debugger] crash when close ide #890

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

LiHua000
Copy link
Contributor

memory release issue

Log: as title

memory release issue

Log: as title
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • DebugSession构造函数中新增了dap::initialize()函数调用,但没有对应的注释说明其用途。
  • dap::terminate()函数在DebugSession析构函数中被调用,但同样没有注释说明其用途。
  • 新增的#include "dap/dap.h"可能会导致头文件重复包含的问题,需要确认是否确实需要此头文件。

是否建议立即修改:

  • 是,建议添加必要的注释来提高代码的可读性和可维护性。
  • 是,需要确认新增的头文件是否必要,并避免潜在的头文件重复包含问题。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart, LiHua000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit de52845 into linuxdeepin:master Aug 16, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants