Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cmake] can not show cmake error at issue list #883

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

LiHua000
Copy link
Contributor

Log: as title

Kakueeen
Kakueeen previously approved these changes Aug 12, 2024
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • appendOutputParser函数中,对outputParser的引用方式从std::unique_ptr<AbstractOutputParser>&更改为std::unique_ptr<AbstractOutputParser> &,这可能会影响到函数的调用和内存管理。需要确认是否有特定的理由进行这种更改,以及是否需要更新相关的调用代码。
  • 在注释中提到的“After appendOutputParser, OutputParser is in a recursive relationship”可能需要更详细的解释,或者更明确的注释,以便其他开发者理解这一变化的原因和影响。
  • 注释中提到的“cmake -> make -> gcc”序列可能需要更明确的文档化,或者在代码中通过命名或注释来反映这一顺序,以提高代码的可读性和可维护性。

是否建议立即修改:

  • 是,需要确保appendOutputParser函数的更改不会导致内存管理或其他相关问题。
  • 是,应该提供更多的上下文信息来解释注释中提到的“recursive relationship”和“cmake -> make -> gcc”的顺序,以便其他开发者理解。

@deepin-mozart deepin-mozart merged commit ee3bba5 into linuxdeepin:master Aug 12, 2024
6 of 7 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart, LiHua000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants