Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix app crash issue #880

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix: Fix app crash issue #880

merged 1 commit into from
Aug 8, 2024

Conversation

Kakueeen
Copy link
Contributor

@Kakueeen Kakueeen commented Aug 8, 2024

The length of the obtained text exceeds the maximum text length

Log: fix issue

The length of the obtained text exceeds the maximum text length

Log: fix issue
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • handleDocumentSemanticTokens函数中,对endPoslineEndPos的比较应该使用>=而不是>来避免潜在的越界问题。
  • sourceText的获取应该确保不会超出行的结束位置,以避免潜在的越界问题。
  • cacheColumn变量在赋值时应该使用++而不是+=,以避免在循环中出现错误的行为。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign toberyan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit 87b9f23 into linuxdeepin:master Aug 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants