Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [debugger] incorrect display of breakpoints`view after file cha… #879

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

LiHua000
Copy link
Contributor

@LiHua000 LiHua000 commented Aug 8, 2024

…nged

Log: as title

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • DAPDebugger::handleEvents函数中,新增的if语句可能会导致不必要的重复检查,建议优化以减少不必要的计算和内存使用。
  • BreakpointModel::insertBreakpoint函数中的beginResetModel();endResetModel();调用可能是不必要的,应该评估是否有更好的方式来处理数据变化时的模型更新。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign toberyan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit a948768 into linuxdeepin:master Aug 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants