Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed code coloring issues #876

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

Kakueeen
Copy link
Contributor

@Kakueeen Kakueeen commented Aug 8, 2024

Fixed an issue where code could not be colored when the project was opened in directory mode

Log: fix issue

Fixed an issue where code could not be colored when the project was opened in directory mode

Log: fix issue
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • extendedproject.h文件中,isValid函数的实现被修改,移除了对outputDirectory的检查,可能会影响函数的预期行为。
  • main.cpp文件中,-j=$(nproc)选项被移除,这可能会改变程序的行为,特别是在多核CPU上运行时。

是否建议立即修改:

  • 是,需要确认这些更改是否符合预期的功能。如果移除-j=$(nproc)选项是无意的,那么应该立即恢复。
  • 是,需要验证isValid函数的修改是否符合预期,因为这可能会影响依赖于这个函数行为的代码部分。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign eric2023 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit 7b5679b into linuxdeepin:master Aug 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants