Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed an issue where files could not be created in file browsing view #874

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Kakueeen
Copy link
Contributor

@Kakueeen Kakueeen commented Aug 8, 2024

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 移除了selNewFolderselNewDocument函数,但保留了createNewcreateNewOperation函数,需要确认这是否是有意为之。
  • createNewOperation函数中的参数pathnewName被添加到函数签名中,这可能是为了提高代码的可读性和明确函数的用途。
  • createCommonActions函数被添加,但它的实现方式依赖于createContextMenucreateEmptyMenu的修改。需要检查这些修改是否与新的createCommonActions函数兼容。

是否建议立即修改:

  • 是,需要确保createNewOperation函数的修改不会影响现有功能,并且与createCommonActions函数的预期用法保持一致。同时,应该验证移除selNewFolderselNewDocument函数是否符合预期的功能需求。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign deepin-mozart for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit 85cc215 into linuxdeepin:master Aug 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants