Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed code coloring issues #871

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Kakueeen
Copy link
Contributor

@Kakueeen Kakueeen commented Aug 8, 2024

Fixed a coloring issue where QT_DEBUG macro could not be recognized

Log: fix issue

Fixed a coloring issue where 'QT_DEBUG' macro could not be recognized

Log: fix issue
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • LanguageWorker::handleDocumentSemanticTokens函数中,使用了textEditor->text(startPos, startPos + val.length)来获取源代码字符串,而不是直接使用val.length来计算字符串长度。这可能是为了确保在处理跨行字符串时能够正确获取源代码。
  • LanguageClientHandlerPrivate::getClient函数中,对projectKey的验证增加了对outputDirectory的检查,确保在调用LSPClientManager::instance()->get(projectKey)时提供了正确的项目键。
  • newlsp::ClientselectLspServer方法中,使用了projectKey.outputDirectory.c_str()来设置--compile-commands-dir参数,这可能是一个错误,因为projectKey.outputDirectory是一个字符串,而不是一个指针。
  • LSPClientManager::get函数中,对projectKey的验证增加了对outputDirectory的检查,确保在调用qApp->metaObject()->invokeMethod(client, "initRequest")时提供了正确的项目键。
  • LanguageClientHandlerPrivate::handleDiagnostics函数中,使用了projectKey.outputDirectory.c_str()来设置qApp->metaObject()->invokeMethod(client, "initRequest")的参数,这可能是一个错误,因为projectKey.outputDirectory是一个字符串,而不是一个指针。

是否建议立即修改:

  • 应该立即修正上述错误,以确保代码的正确性和可靠性。特别是对于projectKey.outputDirectory的错误使用,这可能会导致运行时错误,需要立即修复。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign toberyan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit bec24c5 into linuxdeepin:master Aug 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants