Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [project] set default working directory of Cmake project`s property #828

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

LiHua000
Copy link
Contributor

Log: as title

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • CmakeProjectGenerator::createTargetsRunConfigure函数中,workDirectory参数被错误地使用,应该使用workDirectory而不是workDirectory
  • targetRunConfigure.workDirectory的赋值逻辑可能存在问题,当targetRunConfigure.targetPath不存在时,应该使用workDirectory作为默认值,而不是直接赋值为空字符串。
  • d->workingDirLineEdit->lineEdit()->setReadOnly(true);这行代码被移除,可能会影响用户交互,需要确认这是否是预期的行为。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign toberyan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit bb026c2 into linuxdeepin:develop/dev Jul 25, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants