Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [loading] rename Logo name #827

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

LiHua000
Copy link
Contributor

Log: as title

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 文件名更改可能导致依赖关系不匹配,需要确认新的文件名是否已经在资源文件中定义。
  • 引用图标的主题名称已更改,需要确保新的主题名称已定义并在所有引用的地方更新。
  • 代码中的图标设置使用了硬编码的128px大小,这可能不适用于所有屏幕尺寸,建议使用更灵活的设置。

是否建议立即修改:

  • 是,需要确保文件名和主题名称的更改不会导致资源加载错误或界面显示不正确。
  • 是,建议使用更灵活的图标大小设置,以提高代码的通用性和可维护性。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign eric2023 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit 9292e39 into linuxdeepin:develop/dev Jul 25, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants