Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge from develop #816

Merged
merged 5 commits into from
Jul 24, 2024
Merged

merge from develop #816

merged 5 commits into from
Jul 24, 2024

Conversation

deepin-mozart
Copy link
Contributor

No description provided.

Kakueeen and others added 5 commits July 24, 2024 16:46
@Kakueeen @deepin-mozart
fix: Fixed scrollbar display issue
936cb34 
1.Fixed an issue where the vertical scroll bar obscured the action button in the search results list for Advanced Search
2.Fixed an issue where horizontal scroll bar is not displayed in Project View

Log: fix issues
@LiHua000 @deepin-mozart
fix: [cmake] remove "cancel" action from projcet`s menu
4e42c4c 
Log: as title
@LiHua000 @deepin-mozart
fix: [run] incorret arguments when run/debug application
79a006b 
Log: as title
@Kakueeen @deepin-mozart
fix: Fixed an issue where the completion was abnormal in some scenarios
8ffdfa5 
as title

Log: fix issue
@LiHua000 @deepin-mozart
feat: [codegeex] add options of locale
279a16b 
Log: as title
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在CodeCompletionModel::range方法中，对d->completionDatas.isEmpty()的检查被移除，可能会导致在空列表的情况下错误地返回空范围。
  • executeWithTextEdit方法中的if条件判断逻辑可能不正确，it->toLower() != QChar(character).toLower()比较的是两个字符串的大小写，应该使用==来比较字符。
  • executeWithoutTextEdit方法中的if条件判断逻辑可能不正确，editor()->text(lineStartPos, pos)返回的是一个字符串，应该使用==来比较字符。
  • setCommitsLocale方法被添加到Copilot::instance()->setCommitsLocale中，但未提供修改后的代码，可能会导致编译错误或运行错误。
  • CodeGeeXManager::instance()->setLocale方法被修改，但未提供修改后的代码，可能会导致编译错误或运行错误。
  • resizeEvent方法中，header()->setMinimumSectionSize(minimumWidth);可能会导致列宽不足，应根据实际内容调整列宽。

是否建议立即修改:
是

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart, Kakueeen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit 3b424b9 into linuxdeepin:master Jul 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kakueeen Kakueeen Kakueeen approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepin-mozart @deepin-ci-robot @Kakueeen @LiHua000