Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [run] incorret arguments when run/debug application #810

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

LiHua000
Copy link
Contributor

Log: as title

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LiHua000
Once this PR has been reviewed and has the lgtm label, please assign toberyan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LiHua000 LiHua000 closed this Jul 24, 2024
@LiHua000 LiHua000 reopened this Jul 24, 2024
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • CMakeGenerator::getDebugArguments函数中,新增的"arguments"键可能与现有的键冲突,需要检查是否已有使用该键的代码。
  • CmakeProjectGenerator::createBuildMenu函数中,移除了"Build.Cancel"菜单项,需要确认这是否是有意为之,因为这可能会影响用户体验。
  • ConfigUtil::updateProjectInfo函数中,对iterRun->arguments的处理改变了,使用了split方法,需要确保这一改动不会破坏现有的功能,并且新的方法split是正确的。
  • DapSession::registerHanlder函数中,新增了"--args"字符串到arguments列表,需要检查这一改动是否与调试器的预期行为一致。

是否建议立即修改:

  • 需要确保新增的代码不会引入任何冲突或错误。
  • 对于CmakeProjectGenerator::createBuildMenu的改动,如果移除"Build.Cancel"是故意的,应该有相应的文档或用户提示来告知用户这一变化。
  • 对于ConfigUtil::updateProjectInfo的改动,需要确保调试器能够正确处理新增的"--args"参数。
  • 对于DapSession::registerHanlder的改动,需要验证新的参数添加是否符合调试器的协议和预期行为。

@deepin-mozart deepin-mozart merged commit fbbac7d into linuxdeepin:develop/main Jul 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants