Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [search] Fixed an issue where advanced search could not find results #804

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Kakueeen
Copy link
Contributor

as title

Log: fix issue

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • SearchReplaceWorkerPrivate::parseResultWithRegExpSearchReplaceWorkerPrivate::parseResultWithoutRegExp方法中,使用了QRegularExpression来匹配文本,这可能是一个改进,但需要确保所有使用这些方法的地方都已经做了相应的修改。
  • SearchReplaceWorkerPrivate::processWorkingFiles方法中的参数openedFiles被更改为QStringList &baseFiles,这可能会影响到函数的预期行为,需要确认这是否是预期的更改。
  • SearchReplaceWorkerPrivate::replaceLocalFileSearchReplaceWorkerPrivate::replaceOpenedFile方法中的参数replacement被更改为const QString &replacement,这可能会影响到函数的预期行为,需要确认这是否是预期的更改。

是否建议立即修改:

  • 是,需要确保所有使用parseResultWithRegExpparseResultWithoutRegExpprocessWorkingFilesreplaceLocalFilereplaceOpenedFile方法的地方都已经做了相应的修改,以适应这些更改。同时,需要验证这些更改是否符合预期的功能。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign toberyan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit 30dc2d5 into linuxdeepin:develop/main Jul 23, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants