Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [AI] Code review functionality not working #1046

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

LiHua000
Copy link
Contributor

@LiHua000 LiHua000 commented Jan 7, 2025

leads to long-term unresponsiveness

Log: as title

Bug: https://pms.uniontech.com/bug-view-298309.html

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • postReview 函数中缺少对 url 参数的验证,可能导致无效的URL被传递给网络请求。
  • assembleReviewBody 函数中的 prompt 字段可能需要根据实际需求进行动态生成,而不是硬编码。
  • postReview 函数中 reply->setProperty("responseType", CopilotApi::receiving_by_stream); 这行代码可能需要更多的注释说明其用途。
  • assembleReviewBody 函数中的 QJsonObject json; 对象的创建可以提取为局部变量,以减少作用域。

是否建议立即修改:

Copy link

github-actions bot commented Jan 7, 2025

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "src/plugins/codegeex/copilot.cpp": [
        {
            "line": "static const char *kUrlSSEChat = \"https://codegeex.cn/prod/code/chatCodeSseV3/chat\";",
            "line_number": 17,
            "rule": "S35",
            "reason": "Url link | 9a3dc8cf24"
        },
        {
            "line": "static const char *kUrlGenerateMultiLine = \"https://api.codegeex.cn:8443/v3/completions/inline?stream=false\";",
            "line_number": 18,
            "rule": "S35",
            "reason": "Url link | e01ed92bb3"
        }
    ]
}

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign eric2023 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit ef0d2c1 into linuxdeepin:master Jan 7, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants