Skip to content

refactor: Refactor the ActionManager #1587

refactor: Refactor the ActionManager

refactor: Refactor the ActionManager #1587

Triggered via pull request August 16, 2024 06:00
@KakueeenKakueeen
synchronize #892
Status Success
Total duration 3m 1s
Artifacts

cppcheck.yml

on: pull_request_target
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
cppcheck: src/common/actionmanager/actioncontainer.cpp#L16
Struct 'Group' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
cppcheck: src/common/actionmanager/actioncontainer.cpp#L323
Consider using std::any_of algorithm instead of a raw loop.
cppcheck: src/common/actionmanager/actioncontainer.cpp#L114
The function 'setOnAllDisabledBehavior' is never used.
cppcheck: src/common/actionmanager/actionmanager.cpp#L39
The function 'hasContext' is never used.
cppcheck: src/common/actionmanager/actionmanager.cpp#L208
The function 'unregisterAction' is never used.
cppcheck: src/common/actionmanager/command.cpp#L121
The function 'setDefaultKeySequences' is never used.
cppcheck: src/common/actionmanager/command.h#L29
Class 'Command' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
cppcheck: src/common/actionmanager/commandaction.cpp#L11
Class 'CommandActionPrivate' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
cppcheck: src/common/actionmanager/commandaction.cpp#L191
The function 'commandActionWithIcon' is never used.
cppcheck: src/common/actionmanager/commandaction.cpp#L155
The function 'shortcutVisibleInToolTip' is never used.