Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt treeland #99

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

rb-union
Copy link
Contributor

Adapt Treeland, disable kwayland-shell in
Treeland enviroment.

Log: Adapt Treeland.
Influence: Treeland

Adapt Treeland, disable kwayland-shell in
Treeland enviroment.

Log: Adapt Treeland.
Influence: Treeland
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • isTreeland函数中,使用了qEnvironmentVariable来检查环境变量,但没有考虑环境变量不存在的情况。
  • main函数中,对Application::isWaylandPlatform()的调用后添加了!Application::isTreeland()的逻辑,但没有解释为什么需要这个额外的检查。
  • DWIDGET_INIT_RESOURCE();在代码更改中移除,但没有提供移除的原因或替代方案。

是否建议立即修改:

@pengfeixx
Copy link

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union rb-union merged commit 62cb8be into linuxdeepin:develop/snipe Aug 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants