Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 优化保存后关闭提示 #101

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented Sep 11, 2024

优化保存后关闭提示

Bug: https://pms.uniontech.com/bug-view-269141.html
Log: 优化保存后关闭提示

优化保存后关闭提示

Bug: https://pms.uniontech.com/bug-view-269141.html
Log: 优化保存后关闭提示
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • save函数中,对d_PageContext()->_dirty的赋值操作可能是不必要的,因为save函数的返回值已经包含了保存操作的成功与否信息。
  • 代码中没有对file参数进行有效性检查,可能会导致未处理的异常。

是否建议立即修改:

Copy link
Contributor

@rb-union rb-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myk1343
Copy link
Contributor Author

myk1343 commented Sep 11, 2024

/merge

@deepin-bot deepin-bot bot merged commit bef7ba1 into linuxdeepin:master Sep 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants