Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: printer and scanner driver updates disabled #326

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

Tw1012
Copy link

@Tw1012 Tw1012 commented Jun 18, 2024

Printer or scanner drivers will not be updated,【 Driver Management 】 The interface does not display printer and scanner information

Log: Printer and scanner driver updates disabled
Task: https://pms.uniontech.com/task-view-353401.html

Printer or scanner drivers will not be updated,【 Driver Management 】 The interface does not display printer and scanner information

Log: Printer and scanner driver updates disabled
Task: https://pms.uniontech.com/task-view-353401.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 注释掉的代码 scanDevicesInfo 函数调用被注释掉,可能是为了临时禁用该功能。确认是否有替代方案或者功能将被移除。
  • 检查是否有其他代码依赖于这些被注释掉的调用,如果有,可能会导致编译错误或运行时错误。

是否建议立即修改:

  • 是,需要确认注释掉的代码是否应该被移除,或者是否有其他方式来实现相同的功能。如果有依赖问题,应该立即修复。

@jeffshuai
Copy link

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

Copy link
Contributor

@myk1343 myk1343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, Tw1012

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Tw1012
Copy link
Author

Tw1012 commented Jun 18, 2024

/merge

@deepin-bot deepin-bot bot merged commit 4bf018c into linuxdeepin:master Jun 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants