Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 电池的UPower服务刷新接口 #323

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

Tw1012
Copy link

@Tw1012 Tw1012 commented May 27, 2024

电池的UPower服务刷新接口

Log: 电池的UPower服务刷新接口
Bug: https://pms.uniontech.com/bug-view-254185.html

@Tw1012 Tw1012 force-pushed the master branch 2 times, most recently from cf71398 to e96ce6c Compare May 27, 2024 10:12
电池的UPower服务刷新接口

Log: 电池的UPower服务刷新接口
Bug: https://pms.uniontech.com/bug-view-254185.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码中使用了QProcess来执行Dbus命令,这种方式相对直接调用DBus接口更慢,建议使用直接调用DBus接口的方法。
  • 代码中没有处理QProcess可能产生的错误,例如进程启动失败或读取输出失败。
  • 代码中使用了硬编码的字符串"BAT",这可能导致在电池名称更改时出现问题,建议使用更灵活的方法来匹配电池路径。

是否建议立即修改:

@jeffshuai
Copy link

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

Copy link
Contributor

@myk1343 myk1343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, Tw1012

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Tw1012
Copy link
Author

Tw1012 commented May 27, 2024

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 27, 2024

This pr cannot be merged! (status: unstable)

@Tw1012
Copy link
Author

Tw1012 commented May 27, 2024

/merge

@deepin-bot deepin-bot bot merged commit f140ad8 into linuxdeepin:master May 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants