Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [UI] Add a semi transparent background effect to the sidebar #242

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Aug 19, 2024

Add a semi transparent background effect to the sidebar

Log: [UI] Add a semi transparent background effect to the sidebar
Bug: https://pms.uniontech.com/bug-view-265267.html

  Add a semi transparent background effect to the sidebar

Log: [UI] Add a semi transparent background effect to the sidebar
Bug: https://pms.uniontech.com/bug-view-265267.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • main.cpp文件中,注释掉的代码//qputenv("QML_DISABLE_DISK_CACHE", "1");可能会导致缓存功能被禁用,应确认是否有意为之。
  • AlbumTitle.qml文件中,centerX的计算逻辑可能存在错误,特别是在if (centerX + searchEdit.width > operLayout.x)的分支中。
  • ImportedlListView.qml文件中,importedGridViewCount的属性被移除,但未看到相应的使用或移除的原因说明。
  • main.qml文件中,DWindow.alphaBufferSize的值被硬编码为8,建议使用常量或配置文件来管理此类设置。
  • main.qml文件中,背景色"transparent"和边框色"#11a2a2a2"的值是直接写在代码中的,建议使用常量或配置文件来管理此类设置。

是否建议立即修改:

@pengfeixx
Copy link
Contributor

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@starhcq starhcq merged commit 9456654 into linuxdeepin:master Aug 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants