Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Collection of known problem fixes #233

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix: Collection of known problem fixes #233

merged 1 commit into from
Aug 14, 2024

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Aug 13, 2024

1.Resolve the issue where clicking on the annual cover image cannot accurately locate the monthly view
2.Fixed the issue of occasional blank content views when clicking on the monthly view
3.Add fade in animation effect to the large image preview component
4.Add config for animation duration

Log: Collection of knwon problem fixes

   1.Resolve the issue where clicking on the annual cover image cannot accurately locate the monthly view
   2.Fixed the issue of occasional blank content views when clicking on the monthly view
   3.Add fade in animation effect to the large image preview component
   4.Add config for animation duration

Log: Collection of knwon problem fixes
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • status.setFileControl(fileControl);调用后没有检查返回值,可能会导致未处理的初始化错误。
  • NumberAnimationtarget属性在scrollToYear函数中被赋值,但没有检查target是否为有效对象。
  • yearCollection.flushModel()monthCollection.flushModel()scrollToYearscrollToMonth函数中被调用,但没有检查visible属性。
  • yearPath属性的赋值没有考虑空字符串的情况,可能会导致空指针异常。
  • getYearCoverPath函数中,如果paths为空,应该返回一个空字符串而不是空字符串。
  • setValue函数在loadConfig函数中被调用,但没有检查返回值,可能会导致配置未正确设置。
  • sc_AnimationDuration被移除,但在GlobalStatus::animationDuration()中没有重新赋值,可能会导致运行时错误。

是否建议立即修改:

@starhcq
Copy link
Contributor Author

starhcq commented Aug 14, 2024

@rb-union @pengfeixx

Copy link
Contributor

@pengfeixx pengfeixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@starhcq starhcq merged commit e695c1d into linuxdeepin:master Aug 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants