Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust the logic of the search box clear button function #220

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix: Adjust the logic of the search box clear button function #220

merged 1 commit into from
Jul 24, 2024

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Jul 24, 2024

Adjust the logic of the search box clear button function
1.when user clicked clear button, back to previous view.

Log: Adjust the logic of the search box clear button function
Bug: https://pms.uniontech.com/bug-view-168261.html

   Adjust the logic of the search box clear button function
   1.when user clicked clear button, back to previous view.

Log: Adjust the logic of the search box clear button function
Bug: https://pms.uniontech.com/bug-view-168261.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • executeSearch函数中,beforeView变量被声明但未使用,应该移除或使用。
  • Connections块中的onClicked函数中,searchEdit.beforeView被错误地赋值为-1,应该改为searchEdit.beforeView !== -1以避免潜在的逻辑错误。
  • GStatus.currentViewTypeexecuteSearch函数中被修改,但在onClicked函数中没有看到相应的修改,可能会导致状态不一致。

是否建议立即修改:

Copy link
Contributor

@pengfeixx pengfeixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@starhcq starhcq merged commit a1d4f87 into linuxdeepin:master Jul 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants