Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the issue of abnormal video viewing function #212

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix: Fix the issue of abnormal video viewing function #212

merged 1 commit into from
Jul 17, 2024

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Jul 17, 2024

Fix the issue of abnormal video viewing function

Log: Fix the issue of abnormal video viewing function
Bug: https://pms.uniontech.com/bug-view-229703.html

   Fix the issue of abnormal video viewing function

Log: Fix the issue of abnormal video viewing function
Bug: https://pms.uniontech.com/bug-view-229703.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • albumControl.openDeepinMovie函数中,使用LibUnionImage_NameSpace::isVideo函数来判断视频文件是否正确,这是一个改进,因为避免了直接使用文件扩展名来判断视频格式。
  • albumControl.openDeepinMovie函数中,使用QProcess::startDetached方法来启动外部程序,这是一个好的实践,因为它可以避免外部程序与主程序的耦合。
  • albumControl.openDeepinMovie函数中,使用connect方法来连接QProcessfinished信号,这是一个好的做法,因为它可以确保在进程完成时执行一些清理工作。

是否建议立即修改:

  • 是,因为这些改进可以提高代码的可维护性和可扩展性。特别是对于LibUnionImage_NameSpace::isVideo的使用,这是一个重要的性能提升,因为它避免了直接使用文件扩展名来判断视频格式,从而减少了错误的判断。

@pengfeixx
Copy link
Contributor

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union rb-union merged commit 8ae40f3 into linuxdeepin:master Jul 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants