Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom search engine #6

Closed
wants to merge 3 commits into from

Conversation

kt286
Copy link
Contributor

@kt286 kt286 commented Jun 20, 2022

custom search engine

Log: custom search engine

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck Result

You're A Shining Star!

@zccrs
Copy link
Member

zccrs commented Jun 21, 2022

Thanks. This is a very good feature.

@Clauszy
Copy link
Contributor

Clauszy commented Jun 21, 2022

Thanks. We are reviewing and testing this feature.

Copy link
Contributor

@Clauszy Clauszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestion

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck Result

Fantastic Work!

@kt286 kt286 force-pushed the feat/custom-search-engine branch from adc693a to 054821c Compare June 22, 2022 02:52
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck Result

You're A-OK!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck Result

Awesome!

@kt286 kt286 requested a review from Clauszy June 22, 2022 03:45
Copy link
Contributor

@Clauszy Clauszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

Waiting for a window period to merge this PR.

@kt286 kt286 force-pushed the feat/custom-search-engine branch 2 times, most recently from 57c7cdb to 1c7e8d8 Compare December 20, 2022 09:49
custom search engine

Log: custom search engine
modify for code review

Log: modify for code review
use base64 encoding for URL in config file

Log:use  base64 encoding for URL in config file
@kt286 kt286 force-pushed the feat/custom-search-engine branch from 1c7e8d8 to 3d3fb43 Compare December 20, 2022 09:55
@kt286 kt286 mentioned this pull request Oct 27, 2023
@kt286 kt286 closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants