Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DSL search improvement #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lichaofan2008
Copy link
Contributor

Description:

Log:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lichaofan2008

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Description:

Log:
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 移除了多个类中的m_querysm_worker成员变量,这可能会影响类的功能,需要确认这些变量的移除是否与类的功能相符合。
  • 删除了BaseCond类中的isMatch方法,这可能会影响类的匹配逻辑,需要确认是否有其他方式实现相同的功能。
  • 删除了多个类中的loadCond方法,这可能会影响类的条件加载逻辑,需要确认这些方法的删除是否与类的功能相符合。
  • 删除了DslParser类中的isMatch方法,这可能会影响解析器的匹配逻辑,需要确认是否有其他方式实现相同的功能。
  • 删除了DslParser类的构造函数参数querysfileHandler,这可能会影响解析器的功能,需要确认这些参数的删除是否与类的功能相符合。

是否建议立即修改:

这些修改可能会影响类的功能和性能,需要立即确认这些修改是否符合预期,并确保不会引入新的问题。如果这些修改是无意的或者不符合预期的,应该立即撤销这些修改。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants