fix: icon scaling and improve performance in item delegates #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The icon scaling mechanism was affected by changes in Qt's scaling behavior from qtbase change I563553. This caused incorrect icon sizes when using painter->drawPixmap directly. While QIcon::paint would work correctly, it has significant performance overhead. Changes made: - Calculate proper device pixel ratio scaled size for icons - Maintain aspect ratio when scaling icons to fit target area - Replace QIcon::paint with optimized QPixmap drawing - Use QRectF to avoid rounding errors in icon placement This change improves performance while ensuring correct icon scaling and positioning across different DPI settings. Log: Bug: https://pms.uniontech.com/bug-view-286281.html Bug: https://pms.uniontech.com/bug-view-302075.html Bug: https://pms.uniontech.com/bug-view-296687.html Bug: https://pms.uniontech.com/bug-view-302279.html
as title Log:
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Johnson-zs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit addresses an issue where event registration for certain plugins was failing intermittently due to the order in which plugins were being started. The registration process was not properly synchronized with the plugin lifecycle, leading to missed events. Changes made: - Introduced a mechanism to register plugins only after confirming their startup state. - Added callbacks to ensure that event registration occurs when the corresponding plugin is fully initialized. - Improved the connection handling for plugin state changes to prevent race conditions. This fix enhances the reliability of event registration across plugins and ensures that all necessary events are properly handled during the plugin lifecycle. Log: Bug: https://pms.uniontech.com/bug-view-303391.html
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.