Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [file-dialog] Can not change filter in filedialog. #2548

Open
wants to merge 1 commit into
base: release/eagle
Choose a base branch
from

Conversation

GongHeng2017
Copy link
Contributor

Not clear the records of last filter.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-299607.html

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • initialized信号连接的lambda表达式中,d_func()->lastFilterGroup.clear();d_func()->lastFilter.clear();的调用位置不正确,应该放在if语句的外部,以确保无论条件是否满足,都会执行清理操作。
  • d_func()->lastFilterGroup.clear();d_func()->lastFilter.clear();的调用应该放在if语句内部,以确保只有在条件满足时才执行清理操作。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants