Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance file copy logic for same device checks #2539

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

liyigang1
Copy link
Contributor

  • Updated the check in checkAndCopyFile to ensure that big file copy logic only triggers if the source and target are on the same device.
  • Added a condition to verify device equality using FileUtils::isSameDevice before initiating the big file copy process.

This change improves the file copy operation by preventing unnecessary delays and ensuring that the big file copy logic is only applied when copying files across different devices, enhancing overall performance and reliability.

Log: enhance file copy logic for same device checks

- Updated the check in checkAndCopyFile to ensure that big file copy logic only triggers if the source and target are on the same device.
- Added a condition to verify device equality using FileUtils::isSameDevice before initiating the big file copy process.

This change improves the file copy operation by preventing unnecessary delays and ensuring that
the big file copy logic is only applied when copying files across different devices, enhancing
overall performance and reliability.

Log: enhance file copy logic for same device checks
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • checkAndCopyFile函数中,新增了对源文件和目标文件是否在同一设备上的检查,这可能会影响文件操作的效率。

是否建议立即修改:

  • 否,但建议进行进一步的测试以确保这一改动不会引入新的问题,并且不会对性能产生负面影响。如果测试结果表明这一改动是必要的,并且不会影响性能,那么可以保留这一改动。

@Johnson-zs
Copy link
Contributor

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 7, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit a23af63 into linuxdeepin:master Jan 7, 2025
18 of 20 checks passed
@Johnson-zs
Copy link
Contributor

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 7, 2025

This pr force merged! (status: unknown)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants