Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20241231 eagle fix UI #2530

Closed

Conversation

GongHeng2017
Copy link
Contributor

No description provided.

itsXuSt and others added 30 commits September 2, 2024 10:58
1. uncheck an organized collection;
2. change the wallpaper;
3. crash.

the event is not unsubscribed when collection removed at step 1, when
the wallpaper event emitted, the event handler executed with nullptr,
cause crash.
unsubscribe signal when collection destroyed.

Log: as above.

Bug: https://pms.uniontech.com/bug-view-271449.html
… editor and edit the text

The mimetype method for reading files is inconsistent, and the parameters passed in using openwithdialog are incorrect

Log: Create new text in the SMB server, double-click to open the text editor and edit the text
Bug: https://pms.uniontech.com/bug-view-267705.html
…errors

Local directory attribute box statistics file size and quantity errors

Log: Local directory attribute box statistics file size and quantity errors
add depend libxcb-xfixes0-dev

Log: add depend libxcb-xfixes0-dev
fix property dialog combo box background

Log: fix property dialog combo box backgroun
Bug: https://pms.uniontech.com/bug-view-254101.html
Remove command-line calls through shell parsing, such as bash - c

Log: Remove command line calls through shell parsing
Task: https://pms.uniontech.com/task-view-355351.html
…Occupation Issue

Optimization of 1072 dde-file-manager Search Monitor Indicator Occupation Issue

Log: Optimization of 1072 dde-file-manager Search Monitor Indicator Occupation Issue
Task: https://pms.uniontech.com/task-view-361149.html
If it is not in the root directory of 'crash', do not send 'crash not null' signals

Log: The second directory view of Trash displays a clear button
…ing function are inconsistent

Modify the judgment of right-click sorting

Log: The sorting function of the right-click menu and the header sorting function are inconsistent
Bug: https://pms.uniontech.com/bug-view-271259.html
1. UI change, the right distance is too small on title bar.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-253175.html
…files

QSET did not add URLs in an orderly manner during the complete deletion, resulting in files remaining in the directory but still being deleted

Log: Cannot completely delete directories with subdirectories and subfiles
Add dde-desktop.desktop file to translate dde-desktop

Log: The right-click menu of the dock bar icon displays dde desktop
Bug: https://pms.uniontech.com/bug-view-251773.html
Remove AM adaptation code

Log: Remove AM adaptation code
…indow B deletes or restores the folder, window A returns to the computer path

Add hook event to determine whether to jump to the computer interface

Log: Open multiple trash windows, window A enters the trash folder, window B deletes or restores the folder, window A returns to the computer path
Bug: https://pms.uniontech.com/bug-view-270855.html
…te total file count

The key value for the unix:: mode and filetype in gio corresponding to st_mode in stat is incorrect

Log: Trash select all files, right-click to view properties, inaccurate total file count
Bug: https://pms.uniontech.com/bug-view-270935.html
provide a switcher to control the display total size of block device.

Log: as above

Task: https://pms.uniontech.com/task-view-359665.html
There is a file existence check issue in there. If the file doesn't exist, then the call exists early without authenticating.

Log: sercurity
adjuset the ui of combobox list view.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-251743.html
…usting the window size in grid view

When adjusting the window size, I kept increasing the contentsize

Log: The problem of incorrect scrollbars in the content area when adjusting the window size in grid view
Bug: https://pms.uniontech.com/bug-view-253883.html
collection model source data not updated when files renamed.

Log: as title.

Bug: https://pms.uniontech.com/bug-view-268169.html
…ose another directory (not the current directory). Changing the file name has no effect and the file name is highlighted. However, you still need to click on the file name again with the mouse to enter it

Focus setting issue, set the edit box to focus when highlighted

Log: When taking a screenshot, select "Specify Save Location" and choose another directory (not the current directory). Changing the file name has no effect and the file name is highlighted. However, you still need to click on the file name again with the mouse to enter it
Bug: https://pms.uniontech.com/bug-view-273811.html
…e local device, and the icon may display a probability error

When updating local fileinfo, it was not set to empty

Log: Copy ISO and compressed files from the external device/smb to the local device, and the icon may display a probability error
Bug: https://pms.uniontech.com/bug-view-274169.html
…rs based on keywords in the file content

Modify the word segmentation when establishing an index

Log: There are issues with searching for special characters and numbers based on keywords in the file content
Bug: https://pms.uniontech.com/bug-view-270025.html
liyigang1 and others added 23 commits October 31, 2024 12:51
…tions such as file editors open dde-file-dailog field display

Adjust the adaptive width strategy, and when the window width is less than the width of all columns, adjust the columns larger than the minimum width. When the window width is greater than the width of all columns, adjust the width of the filename column

Log: After adjusting the width of the dde-file-manager, other applications such as file editors open dde-file-dailog field display
Bug: https://pms.uniontech.com/bug-view-273831.html
Add support for WebDAV (dav/davs) and NFS network protocols in file
manager. This includes:

- Add new protocol schemes 'dav', 'davs' and 'nfs' to global defines
- Register new protocols in SmbBrowser plugin for handling network
shares
- Add default port (2049) for NFS protocol
- Update mount dialog to support new protocols without domain field
- Update network access pre-handlers for new protocols
- Refactor SmbBrowser plugin initialization code for better
maintainability

Log: SmbBrowser plugin now handles all network share protocols (SMB/FTP/
SFTP/WebDAV/NFS)

Task: https://pms.uniontech.com/task-view-366623.html
Add a stop condition check in TraversalDirThreadManager::createFileInfo to
properly handle interruption requests during file info creation process.

- Add stopFlag check in the file info creation loop
- Early return when stopFlag is set to prevent unnecessary operations
- Improve responsiveness when canceling directory traversal

This change ensures the traversal operation can be stopped promptly when
requested by the user or system.

Log: Switching directory lag
Bug: https://bbs.deepin.org/post/281034
Modify symlink handling in DoCutFilesWorker to defer deletion until after
successful link creation:

- Replace immediate deletion with deferred deletion via cutAndDeleteFiles list
- Only add symlink to deletion list if creation was successful
- Maintain existing completion tracking behavior

This change prevents premature deletion of symlinks and ensures atomic
cut operations for symbolic links.

Log: improve symlink handling during cut operations
Bug: https://pms.uniontech.com/bug-view-278451.html
…andling

Fix memory management of QElapsedTimer objects in AbstractWorker:

- Store deleted timers in speedtimerList instead of immediate deletion
- Add cleanup of timer list in destructor using qDeleteAll
- Maintain existing pause/resume functionality

This change prevents potential memory leaks when pausing/resuming file
operations while properly managing timer resources.

Log: dde-file-manager copy crash
Bug: https://pms.uniontech.com/bug-view-279983.html
When gtk show file selecet dialog, the name filter
show the details text.

Log: fix issue
Bug: https://pms.uniontech.com//bug-view-286169.html
Move prefixMap and prefixKeys from static variables to const member variables
in EventPrivate class to avoid static initialization/destruction order issues
and ensure thread safety.

Log: fix crash
- Fix inverted return condition for copy operation success
- Return true when NextDo is kDoCopyNext indicating successful copy
- Maintain consistent success/failure state with other copy methods

This change fixes a logical error where the copy success state was
incorrectly inverted, ensuring proper flow control in range-based
file copy operations.

Log: correct return value logic in doCopyLocalByRange
Bug: https://pms.uniontech.com/bug-view-290241.html
…the desktop icon

1. When the icon of a desktop file is in svg format and the mouse moves over the file,
QIcon is frequently invoked to create an object, resulting in high cpu usage.
2. svg availableSizes returns a null value, causing the cache QIcon to be emptied,
resulting in not only a rebuild, but also a high cpu utilization.
3. Remove the judgment of availableSizes.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-289327.html
Logic error,the gio emblem not show the right pos.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-278805.html
Show the dbus memory of install.

Log: fix issue
Calculate correct content height for list/tree mode to ensure proper scrolling

Log: fix list view issue
Bug: https://pms.uniontech.com/bug-view-291285.html
    Add judgment, save mode, do not perform accept oprations directly.
1. Add thread assertion in DialogManager singleton:
   - Ensure DialogManager is only accessed from main thread
   - Add Q_ASSERT check for thread safety

2. Fix rename file operation issues:
   - Make needCheck parameter explicit in LocalFileHandler::renameFile
   - Pass correct needCheck flag in different rename scenarios:
     * Set to false for cut operations
     * Set to true for direct rename operations

3. Code style improvements:
   - Fix spacing in variable initialization
   - Improve code formatting for better readability

This fixes potential crashes when showing dialogs from non-main threads and improves rename operation reliability.

Log: fix crash
…ager crash

- Updated clipboard reading method to use static access for readFirstClipboard
- Ensured proper cleanup of local server in SingleApplication destructor
- Enhanced connection handling in ClipboardMonitor to prevent memory leaks
- Added stop method in Computer class to clear async threads
- Improved async thread management in ComputerItemWatcher
- Refactored signal-slot connections for better clarity and performance

This change enhances the clipboard handling logic by ensuring that the
clipboard is read correctly and efficiently. It also improves resource
management by ensuring proper cleanup of connections and async threads,
preventing potential memory leaks and improving overall application stability.

Log: improve clipboard handling and resource management, dde-file-manager crash
Bug: https://pms.uniontech.com/bug-view-279983.html
- Added caching for additional time-related attributes:
  - TimeChanged
  - TimeModified
  - TimeChangedUsec
  - TimeModifiedUsec
- Removed redundant insertions of time-related attributes from the temporary map to streamline the caching process

This change improves the attribute caching mechanism in the AsyncFileInfo class by ensuring that
relevant time attributes are properly cached, enhancing the accuracy and performance of file
information retrieval.

Log: enhance attribute caching in AsyncFileInfo
When the recent file manager starts, it now properly handles the case
where the xbel file doesn't exist. This fix:

- Add existence check for xbel file
- Create empty xbel file if not exists
- Add proper error handling and logging
- Ensure file watcher starts correctly

This ensures the recent file manager works properly on first run or
when the xbel file is missing.

Log:

Bug: https://pms.uniontech.com/bug-view-296569.html
remove invalid  url

Log: remove invalid  url
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

  • 检测到debian目录文件有变更: debian/control,debian/dde-file-manager.install,debian/libdde-file-manager.postinst

@deepin-ci-robot
Copy link

deepin pr auto review

--
2.39.1

Copy link

TAG Bot

TAG: 6.1.0
EXISTED: yes
DISTRIBUTION: unstable

Copy link

  • 敏感词检查失败, 检测到5个文件存在敏感词
详情
{
    "src/apps/dde-file-manager/main.cpp": [
        {
            "line": "    a.setApplicationAcknowledgementPage(\"https://www.deepin.org/acknowledgments/\" + qApp->applicationName());",
            "line_number": 292,
            "rule": "S35",
            "reason": "Url link | e56e98a089"
        }
    ],
    "src/plugins/common/core/dfmplugin-fileoperations/fileoperationsevent/fileoperationseventreceiver.cpp": [
        {
            "line": "            key = \"Name\";",
            "line_number": 364,
            "rule": "S106",
            "reason": "Var naming | ff5dbee3ee"
        }
    ],
    "src/plugins/filemanager/core/dfmplugin-trash/trash.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "src/plugins/filemanager/dfmplugin-smbbrowser/smbbrowser.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "debian/control": [
        {
            "line": "Homepage: http://www.deepin.org",
            "line_number": 49,
            "rule": "S35",
            "reason": "Url link | 6fe814dfb7"
        }
    ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants