Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [tab-bar] close button ui show error #2034

Merged

Conversation

GongHeng2017
Copy link
Contributor

Adjust the close button size.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-259201.html

@GongHeng2017 GongHeng2017 reopened this Jun 20, 2024
@GongHeng2017 GongHeng2017 reopened this Jun 21, 2024
@GongHeng2017 GongHeng2017 force-pushed the 20240620-master-buttonShowError branch from 7129939 to 43e109c Compare June 24, 2024 03:27
@GongHeng2017 GongHeng2017 reopened this Jun 24, 2024
@GongHeng2017 GongHeng2017 force-pushed the 20240620-master-buttonShowError branch from 43e109c to df1e86d Compare June 25, 2024 03:03
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • TabBar::mouseMoveEventTabBar::handleTabAnimationFinished函数中,使用了硬编码的数字来判断按钮大小,建议使用常量或配置文件来管理这些值。
  • tabCloseButton->setPos函数中的计算方式可能会导致按钮位置计算不准确,建议使用更精确的方法来计算按钮位置。

是否建议立即修改:

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 26, 2024

TAG Bot

New tag: 6.0.53
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #2050

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GongHeng2017
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit a0a366b into linuxdeepin:master Jun 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants