Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [titlebar] AT issue #2024

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

Lighto-Ku
Copy link
Contributor

set accessible name of treeview btn in titlebar

Log: fix test issue

set accessible name of treeview btn in titlebar

Log: fix test issue
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • OptionButtonBox::initializeUi函数中,新增代码块没有处理d->treeViewButtonnullptr的情况,可能会导致空指针解引用。
  • 新增代码块没有使用if语句,而是直接判断d->treeViewButton是否为nullptr,这可能会导致代码的可读性降低。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, Lighto-Ku

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Lighto-Ku
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 7499363 into linuxdeepin:master Jun 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants