Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AVIF and HEIC format images are displayed in the preview window with a size of 0X0 #2018

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

liyigang1
Copy link
Contributor

If the size is 0x0 or empty, it will not be displayed

Log: AVIF and HEIC format images are displayed in the preview window with a size of 0X0
Bug: https://pms.uniontech.com/bug-view-259579.html

…with a size of 0X0

If the size is 0x0 or empty, it will not be displayed

Log: AVIF and HEIC format images are displayed in the preview window with a size of 0X0
Bug: https://pms.uniontech.com/bug-view-259579.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • slotImageExtenInfoslotVideoExtenInfo函数中,增加了对properties参数的空值检查和"0x0"前缀的过滤,这有助于避免潜在的运行时错误。
  • 修改了fileDuration的显示条件,确保在properties列表中至少有两个元素时才会显示。

是否建议立即修改:

  • 否,当前提交的修改看起来是合理的,没有发现需要立即修改的关键问题。但是,建议进行以下几点额外的审查:
    • 确认对"0x0"前缀的过滤是否适用于所有情况下。
    • 检查properties.count() > 1的使用是否正确,确保它不会导致数组越界异常。
    • 确保fileViewSizefileDuration的可见性设置逻辑在所有情况下都是正确的。
    • 考虑添加注释来解释为什么需要对properties进行空值检查和"0x0"前缀过滤。
    • 确保这些修改与整体代码库的其余部分保持一致的编码风格和逻辑。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liyigang1
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 3224158 into linuxdeepin:master Jun 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants