fix: Delete the file and recall it with Ctrl+Z, displaying an error pop-up window in dde-file-dailog #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyigang1
force-pushed
the
fix-2
branch
4 times, most recently
from
a3d603d to
9f2109e
Compare
max-lvs
reviewed
Jun 11, 2024
| @@ -292,6 +286,173 @@ bool DoRestoreTrashFilesWorker::checkRestoreInfo(const QUrl &url, FileInfoPointe | |||
| return result; | |||
| } | |||
|
|
|||
| bool DoRestoreTrashFilesWorker::doCheckRestoreFromTrashFile(const DFileInfo &fromInfo, const FileInfoPointer &toInfo, const QString &fileName, FileInfoPointer &newTargetInfo, bool *skip) | |||
There was a problem hiding this comment.
代码冗余太多，需要合并优化，在filebasework里面有了。
…op-up window in dde-file-dailog Failure to load the trashcore plugin resulted in no trashinfo creation failure. Use dfileinfo to read data during restore Log: Delete the file and recall it with Ctrl+Z, displaying an error pop-up window in dde-file-dailog Bug: https://pms.uniontech.com/bug-view-254735.html
deepin pr auto reviewFix crash in fileoperations plugin |
max-lvs
approved these changes
Jun 18, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liyigang1, max-lvs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure to load the trashcore plugin resulted in no trashinfo creation failure. Use dfileinfo to read data during restore
Log: Delete the file and recall it with Ctrl+Z, displaying an error pop-up window in dde-file-dailog
Bug: https://pms.uniontech.com/bug-view-254735.html