Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Open interface and script tweak #2011

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

kegechen
Copy link
Contributor

@kegechen kegechen commented Jun 5, 2024

@kegechen
Copy link
Contributor Author

kegechen commented Jun 5, 2024

/review @max-lvs @Johnson-zs

@kegechen kegechen changed the title chore: add OpenWith interface and script tweak chore: add Open interface and script tweak Jun 13, 2024
@kegechen kegechen force-pushed the openwith branch 3 times, most recently from a301078 to 16d7ec5 Compare June 14, 2024 02:28
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Open方法中,使用file-manager.sh代替dde-file-manager可能会导致不一致的行为,因为file-manager.sh可能不是所有用户都配置的。
  • args=${args%,}这行代码可能会导致问题,因为它移除了逗号,但在其他地方没有看到对args变量进行类似的操作。
  • if (QProcess::startDetached("file-manager.sh", QStringList() << Args))这行代码中,如果file-manager.sh不存在,startDetached将返回false,但程序似乎没有处理这种情况。
  • dbus-send命令在调用Open方法时没有使用--print-reply选项,这可能会导致调试困难,因为发送的消息不会返回任何错误信息。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, kegechen, liyigang1

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 59e7bb3 into linuxdeepin:master Jun 14, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants