Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: After selecting "Cancel" when revoking, attempting to do so again will skip the previous operation's revocation #2010

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

liyigang1
Copy link
Contributor

The stack order of the save file operation is incorrect

Log: After selecting "Cancel" when revoking, attempting to do so again will skip the previous operation's revocation
Bug: https://pms.uniontech.com/bug-view-257853.html

liyigang1 added 2 commits June 4, 2024 11:42
…n will skip the previous operation's revocation

The stack order of the save file operation is incorrect

Log: After selecting "Cancel" when revoking, attempting to do so again will skip the previous operation's revocation
Bug: https://pms.uniontech.com/bug-view-257853.html
Incorrect search status setting

Log: The full-text search function is not effective
Bug: https://pms.uniontech.com/bug-view-256997.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FileOperationsEventReceiver::handleOperationUndoDeletes函数中,对op变量的引用可能不正确,因为op在循环中被修改,但在循环外部仍然保持不变。
  • FullTextSearcherPrivate::createIndex函数中,status.storeRelease(AbstractSearcher::kCompleted);这行代码被移除,可能会影响程序的逻辑。如果移除这行代码是有意为之,应该确保这一改动不会对程序的其他部分产生负面影响。
  • OperationsStackManagerDbus::SaveOperationsOperationsStackManagerDbus::SaveRedoOperations函数中的代码被简化,移除了对back变量的处理,这可能会改变操作的顺序。需要确认这是否是预期的行为。

是否建议立即修改:

  • 是,需要确认这些更改是否符合预期的逻辑,并确保程序的其他部分能够正确处理这些更改。如果这些更改是无意的,应该立即修复。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liyigang1
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 92fe99e into linuxdeepin:master Jun 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants