Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: After checking the box, the document management selection window will not be able to enter any directory when a new window is opened #1994

Closed
wants to merge 1 commit into from

Conversation

liyigang1
Copy link
Contributor

Set filedailog to only open in the current window

Log: After checking the box, the document management selection window will not be able to enter any directory when a new window is opened
Bug: https://pms.uniontech.com/bug-view-255979.html

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… will not be able to enter any directory when a new window is opened

Set filedailog to only open in the current window

Log: After checking the box, the document management selection window will not be able to enter any directory when a new window is opened
Bug: https://pms.uniontech.com/bug-view-255979.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • WorkspaceEventReceiver类中,handleSetAlwaysOpenInCurrentWindow函数缺少对windowID是否有效的检查。
  • setAlwaysOpenInCurrentWindow函数中,如果findFileViewByWindowID找不到对应的文件视图,应该处理这种情况。
  • handleSetCustomFilterDatahandleSetCustomFilterCallback函数中,应该检查scheme是否有效,以及callback函数是否为nullptr

是否建议立即修改:

@liyigang1 liyigang1 closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants