Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [drag] Drag action error. #1988

Merged
merged 1 commit into from
May 17, 2024

Conversation

GongHeng2017
Copy link
Contributor

  1. Drag Action is set up from a third -party application, but the desktop does not perform drag behavior according to the Action execution.
  2. Modify the code and identify the source of the DRAG event. If it is a third -party application, the desktop and the cultural tube will not modify this drop action.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-252557.html

1. Drag Action is set up from a third -party application,
but the desktop does not perform drag behavior according to the Action execution.
2. Modify the code and identify the source of the DRAG event.
If it is a third -party application, the desktop and the cultural tube will not modify this drop action.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-252557.html
@GongHeng2017 GongHeng2017 force-pushed the 20240516-master-fixDrag branch from 04ce9a0 to 6cde217 Compare May 16, 2024 09:45
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在所有新增的代码中,都检查了MIME数据是否包含kDFMAppTypeKey,但没有检查是否包含其他必要的MIME类型,可能会导致在不支持所需MIME数据的drop event上跳过处理。
  • 新增的代码增加了代码的复杂性,但没有明显的性能问题,但应确保这种检查不会成为性能瓶颈。

合并相似的问题是否建议立即修改:

  • 是,建议立即修改以确保代码的健壮性和性能。特别是对于MIME数据的验证,应该考虑全面性,而不仅仅是添加对kDFMAppTypeKey的检查。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GongHeng2017
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 9b192ba into linuxdeepin:master May 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants