Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [254647/dock] device list might be shorten #1986

Merged
merged 1 commit into from
May 20, 2024

Conversation

itsXuSt
Copy link
Contributor

@itsXuSt itsXuSt commented May 13, 2024

use resize to adjust the size of device list.

Log: as title.

Bug: https://pms.uniontech.com/bug-view-254647.html

use `resize` to adjust the size of device list.

Log: as title.

Bug: https://pms.uniontech.com/bug-view-254647.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • DeviceList类的showEvent函数中,调用setFixedHeight被替换为resize,可能会影响窗口的布局和响应式设计。
  • 移除了showEvent的访问修饰符,如果其他类需要访问showEvent逻辑,可能会导致封装破坏。

是否建议立即修改:

  • 是,应该评估resizesetFixedHeight的使用场景,确保它们的行为一致并且不会破坏现有的布局和响应式设计。
  • 是,如果showEvent是类的重要逻辑,不应该轻易移除访问修饰符,以避免潜在的封装破坏。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@itsXuSt
Copy link
Contributor Author

itsXuSt commented May 20, 2024

/merge

@deepin-bot deepin-bot bot merged commit c8b9d53 into linuxdeepin:master May 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants