Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error in modifying the setting area #1994

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

caixr23
Copy link
Contributor

@caixr23 caixr23 commented Jan 9, 2025

Error in modifying the setting area

pms: BUG-299233

Error in modifying the setting area

pms: BUG-299233
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 循环遍历 m_regions 可能会导致性能问题,如果 m_regions 非常大。
  • locale.territoryToCode(locale.territory())locale.countryToString(locale.country()) 的调用可能不是必要的,如果 reg 已经是所需的值。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, xionglinlin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23 caixr23 merged commit 747ea1f into linuxdeepin:master Jan 10, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants