Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support trash and computer scheme #117

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

asterwyx
Copy link
Contributor

Forward scheme handler of trash and computer to inode/directory's handler.

Log: support trash and computer scheme
Issue: linuxdeepin/developer-center#8266

Forward scheme handler of trash and computer to inode/directory's
handler.

Log: support trash and computer scheme
Issue: linuxdeepin/developer-center#8266
@asterwyx asterwyx requested review from BLumia and black-desk April 28, 2024 08:55
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • openScheme函数中,对appInfo的判断逻辑可能存在错误,应该先检查appInfo是否为nil,然后再判断scheme是否为"trash""computer"
  • gio.AppInfoGetDefaultForType函数的第二个参数应该是true,而不是nil,因为在gio库的文档中,gio.AppInfoGetDefaultForType的第二个参数是一个bool类型的标志,用于表示是否使用系统默认的AppInfo。

合并相似的问题是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx, BLumia

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia
Copy link
Member

BLumia commented Apr 28, 2024

/merge

@deepin-bot deepin-bot bot merged commit 95c2fd8 into linuxdeepin:master Apr 28, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants